docs(files): note CORS_EXPOSED_HEADERS requirement for TUS Directus-File-Id#642
Closed
singhvishalkr wants to merge 1 commit intodirectus:mainfrom
Closed
docs(files): note CORS_EXPOSED_HEADERS requirement for TUS Directus-File-Id#642singhvishalkr wants to merge 1 commit intodirectus:mainfrom
singhvishalkr wants to merge 1 commit intodirectus:mainfrom
Conversation
|
@singhvishalkr is attempting to deploy a commit to the Directus Team on Vercel. A member of the Team first needs to authorize it. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #599.
v11.16+returns the uploaded file's ID in aDirectus-File-Idresponse header after a TUS chunked upload. When the frontend is on a different origin from the API, browsers don't expose that header to JavaScript unless it's listed inAccess-Control-Expose-Headers, so reading the ID fromxhr.getResponseHeader('Directus-File-Id')silently returnsnull.I hit this myself and spent a while staring at the Network tab before finding the issue, which is also the exact gotcha the report describes. ComfortablyCoding confirmed on the issue that the right fix is documentation -- not a default change -- so I added a small callout in the existing Chunked Uploads section pointing at
CORS_EXPOSED_HEADERSon the Security & Limits page.No variable or behavior changes, just the note.